[U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error

Kever Yang kever.yang at rock-chips.com
Fri Jul 5 07:33:12 UTC 2019


Hi Christoph,

    Could you check this issue on your side?

    This is pretty important for rk3399, this will break the support for ATF

for rk3399 boards other than puma.


On 07/04/2019 05:44 PM, Andy Yan wrote:
> Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set
> firmware = "atf_1";
> loadables = "uboot","atf_1","atf_2";
>
> Actually it should be:
> firmware = "atf_1";
> loadables = "uboot","atf_2","atf_3";
>
> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>
>  arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
> index 45ec105887..db0ae96ca8 100755
> --- a/arch/arm/mach-rockchip/make_fit_atf.py
> +++ b/arch/arm/mach-rockchip/make_fit_atf.py
> @@ -94,7 +94,7 @@ def append_conf_section(file, cnt, dtname, segments):
>      if segments != 0:
>          file.write(',')
>      for i in range(1, segments):
> -        file.write('"atf_%d"' % (i))
> +        file.write('"atf_%d"' % (i + 1))
>          if i != (segments - 1):
>              file.write(',')
>          else:





More information about the U-Boot mailing list