[U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error

Christoph Müllner christoph.muellner at theobroma-systems.com
Fri Jul 5 09:15:30 UTC 2019



On 04.07.19 11:44, Andy Yan wrote:
> Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set
> firmware = "atf_1";
> loadables = "uboot","atf_1","atf_2";
> 
> Actually it should be:
> firmware = "atf_1";
> loadables = "uboot","atf_2","atf_3";

Does "atf_1" not need to be among loadables as well?
My version of the script produces:

loadables = "uboot","atf_1","atf_2","atf_3";

And with that I was able to boot mainline ATF.

> 
> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
> ---
> 
>  arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
> index 45ec105887..db0ae96ca8 100755
> --- a/arch/arm/mach-rockchip/make_fit_atf.py
> +++ b/arch/arm/mach-rockchip/make_fit_atf.py
> @@ -94,7 +94,7 @@ def append_conf_section(file, cnt, dtname, segments):
>      if segments != 0:
>          file.write(',')
>      for i in range(1, segments):
> -        file.write('"atf_%d"' % (i))
> +        file.write('"atf_%d"' % (i + 1))
>          if i != (segments - 1):
>              file.write(',')
>          else:
> 


More information about the U-Boot mailing list