[U-Boot] [PATCH v2 1/3] rockchip: rk3399: derive ethaddr from cpuid

[Rohan Garg]

Hey Kever

> 
> This should be depends on CONFIG_MISC_INIT_R.
>

Ack.
 
> 
> It's great to make these code as common code so that other SoCs
> 
> can share it, is it possible to also make this function common?
> 
> Not every SoC have efuse driver, so for those SoCs, we need a random
> 
> serial No.
> 

Do you think we can merge this as is for now and then move onto making it more 
generic for other devices at a later date?

> > +	const u32 cpuid_offset = 0x7;
> > +	const u32 cpuid_length = 0x10;
> > +	u8 cpuid[cpuid_length];
> > +
> > +	rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid);
> > +	rockchip_cpuid_set(cpuid, cpuid_length);
> > +	rockchip_setup_macaddr();
> 
> It will be better for these function calls with return value.
> 
> There should be a blank line before 'return';

Ack.

Cheers
Rohan Garg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190719/8e070447/attachment.sig>