[U-Boot] [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

Wolfgang Denk wd at denx.de
Thu Jul 25 07:41:21 UTC 2019


Dear Chuanhua Han,

In message <20190725043934.30236-4-chuanhua.han at nxp.com> you wrote:
> This patch adds the ds3232-rtc node under the i2c0->i2c-mux at 77->i2c at 0
> for ls2088aqds boards.

Is this bisectable?  You first enable the feature in the code, and
only later add the needed property to the DT?  Should it not be
reversed?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why don't you have a Linux partition installed so you can be  working
in  a  programmer-friendly environment instead of a keep-gates'-bank-
account-happy one? :-)                            -- Tom Christiansen


More information about the U-Boot mailing list