[U-Boot] [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

Chuanhua Han chuanhua.han at nxp.com
Thu Jul 25 09:23:09 UTC 2019



> -----Original Message-----
> From: Wolfgang Denk <wd at denx.de>
> Sent: 2019年7月25日 15:41
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: albert.u.boot at aribaud.net; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>;
> Rajesh Bhagat <rajesh.bhagat at nxp.com>; u-boot at lists.denx.de;
> lukma at denx.de; trini at konsulko.com
> Subject: [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node
> 
> Caution: EXT Email
> 
> Dear Chuanhua Han,
> 
> In message <20190725043934.30236-4-chuanhua.han at nxp.com> you wrote:
> > This patch adds the ds3232-rtc node under the i2c0->i2c-mux at 77->i2c at 0
> > for ls2088aqds boards.
> 
> Is this bisectable?  You first enable the feature in the code, and only later add
> the needed property to the DT?  Should it not be reversed?
This should not matter because they are in the same patch set
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Why don't you have a Linux partition installed so you can be  working in  a
> programmer-friendly environment instead of a keep-gates'-bank-
> account-happy one? :-)                            -- Tom Christiansen


More information about the U-Boot mailing list