[U-Boot] [PATCH 2/2] net: mdio: Clarify code flow Covarity 244085 & 244090
Joe Hershberger
joe.hershberger at ni.com
Tue Jul 30 21:57:57 UTC 2019
Document that the lack of breaks is intentional.
Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
---
cmd/mdio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/mdio.c b/cmd/mdio.c
index add6440813..22c8fbe856 100644
--- a/cmd/mdio.c
+++ b/cmd/mdio.c
@@ -253,12 +253,13 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
case 'w':
if (pos > 1)
data = simple_strtoul(argv[pos--], NULL, 16);
+ /* Intentional fall-through - Get reg for read and write */
case 'r':
if (pos > 1)
if (extract_reg_range(argv[pos--], &devadlo, &devadhi,
®lo, ®hi))
return CMD_RET_FAILURE;
-
+ /* Intentional fall-through - Get phy for all commands */
default:
if (pos > 1)
if (extract_phy_range(&argv[2], pos - 1, &bus,
--
2.11.0
More information about the U-Boot
mailing list