[U-Boot] [PATCH 1/2] net: Fix Covarity Defect 244093

Joe Hershberger joe.hershberger at ni.com
Tue Jul 30 21:57:56 UTC 2019


Don't allow unterminated strings

Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
---

 net/mdio-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c
index 36a404ff44..1c0d25272a 100644
--- a/net/mdio-uclass.c
+++ b/net/mdio-uclass.c
@@ -75,7 +75,7 @@ static int dm_mdio_post_probe(struct udevice *dev)
 	pdata->mii_bus->write = mdio_write;
 	pdata->mii_bus->reset = mdio_reset;
 	pdata->mii_bus->priv = dev;
-	strncpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN);
+	strncpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN - 1);
 
 	return mdio_register(pdata->mii_bus);
 }
-- 
2.11.0



More information about the U-Boot mailing list