[U-Boot] [PATCH 1/2] configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER

[Lokesh Vutla]

On 30/07/19 9:48 PM, Tom Rini wrote:
> On Tue, Jul 30, 2019 at 11:16:19AM -0500, Suman Anna wrote:
>> Hi Lokesh,
>>
>> On 7/29/19 11:08 PM, Lokesh Vutla wrote:
>>>
>>>
>>> On 29/07/19 10:18 PM, Suman Anna wrote:
>>>> The K3 System Controller driver is used for loading and starting
>>>> the System Firmware, and is used only on R5 SPL. It need not be
>>>> enabled and built for the A53 U-Boot and SPL, so disable it from
>>>> both the GP and HS AM65x A53 defconfigs.
>>>>
>>>> While at this, also remove the unneeded CONFIG_SPL_REMOTEPROC and
>>>> CONFIG_CMD_REMOTEPROC as no remoteprocs are now loaded from A53 SPL.
>>>>
>>>> Signed-off-by: Suman Anna <s-anna at ti.com>
>>>> ---
>>>>  configs/am65x_evm_a53_defconfig    | 3 ---
>>>>  configs/am65x_hs_evm_a53_defconfig | 3 ---
>>>>  2 files changed, 6 deletions(-)
>>>>
>>>> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
>>>> index 2cf3a693fc70..d43df6a18765 100644
>>>> --- a/configs/am65x_evm_a53_defconfig
>>>> +++ b/configs/am65x_evm_a53_defconfig
>>>> @@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y
>>>>  CONFIG_SPL_DM_MAILBOX=y
>>>>  CONFIG_SPL_DM_RESET=y
>>>>  CONFIG_SPL_POWER_DOMAIN=y
>>>> -CONFIG_SPL_REMOTEPROC=y
>>>>  CONFIG_SPL_YMODEM_SUPPORT=y
>>>>  CONFIG_CMD_ASKENV=y
>>>>  # CONFIG_CMD_FLASH is not set
>>>>  CONFIG_CMD_GPT=y
>>>>  CONFIG_CMD_I2C=y
>>>>  CONFIG_CMD_MMC=y
>>>> -CONFIG_CMD_REMOTEPROC=y
>>>
>>> CMD_REMOTEPROC will definitely be used in very near future. Please retain this.
>>> Rest looks good to me.
>>
>> This is a result of using savedefconfig, I prefer it this way since it
>> allows other developers adding options to do it cleanly. If and when a
>> REMOTEPROC is enabled, the savedefconfig with corresponding options
>> should automatically bring this back.
> 
> Indeed, if savedefconfig is taking it out, it's not being built today OR
> it's already default y and being built.
> 

ohh okay. I didn't know it was a result of savedefconfig as you mentioned it is
explicitly removed. Patch as such looks good to me.

Reviewed-by: Lokesh Vutla <lokeshvutla at ti.com>

Thanks and regards,
Lokesh