[U-Boot] [PATCH] arm: socfpga: make SPL_TEXT_BASE overridable

[Marek Vasut]

On 3/16/19 1:36 PM, Simon Goldschmidt wrote:
> 
> 
> On Saturday, March 16, 2019, Marek Vasut <marex at denx.de
> <mailto:marex at denx.de>> wrote:
> 
>     On 3/16/19 9:23 AM, Simon Goldschmidt wrote:
>     > Am 15.03.2019 um 22:20 schrieb Marek Vasut:
>     >> On 3/15/19 8:44 PM, Simon Goldschmidt wrote:
>     >>> To boot from fpga on socfpga gen5, we need to set
>     >>> CONFIG_SPL_TEXT_BASE to
>     >>> 0xC0000000 (hps2fpgaslaves base address).
>     >>>
>     >>> Since converting CONFIG_SPL_TEXT_BASE to Kconfig hasn't been
>     >>> successful so
>     >>> far, let's make this value overridable in socfpga_common.h, so that
>     >>> we can
>     >>> have different board configs override this in socfpga_common.h.
>     >>>
>     >>> Signed-off-by: Simon Goldschmidt
>     <simon.k.r.goldschmidt at gmail.com
>     <mailto:simon.k.r.goldschmidt at gmail.com>>
>     >>
>     >> Is this a fix for current release or new feature for next ?
>     >
>     > Yes, it's a fix for the current release. It's the only thing
>     missing to
>     > *finally* get mainline SPL booting from FPGA (on socfpga gen5).
>     >
>     > As written in the log, the original plan was to move
>     > CONFIG_SPL_TEXT_BASE to Kconfig completely, but that didn't work out
>     > (still), which is why we have to do it in a different way.
>     >
>     > I could provide a new board config to boot from FPGA if you want, but
>     > that did not make much sense to me as the FPGA image would be
>     missing...
> 
>     Well, applied.
> 
> 
> Thanks.
>  
> 
> 
>     That said, do you plan to work on the Kconfig conversion further ?
>     What's the problem there ?
> 
> 
> I started that conversion (still in patchwork) but Tom said it produced
> errors
> and he kind of took it further. I'm not really on track what's still
> missing.
> 
> But of course I would still prefer the Kconfig version instead of this
> #ifndef...

Always :)

-- 
Best regards,
Marek Vasut