[U-Boot] [PATCH 09/12 v2] Makefile: Add Kconfig option CONFIG_SPL_IMAGE to select the SPL binary

[Stefan Roese]

On 29.03.19 16:59, Eugen.Hristev at microchip.com wrote:

<snip>

>>> And after this patch, there will
>>> also be a new binary u-boot-with-spl.bin, except spl/boot.bin and
>>> spl/u-boot-spl.bin ?
>>
>> The old binaries are still generated. Only a new combined image is
>> generated too.
>>
>>> Thus your patch does a bit more than what it's explained in the commit
>>> message ?
>>
>> Does it? What exactly is missing in the commit message? Please explain
>> and I'll add something in the next patch version.
> 
> A new binary is generated on build after this patch is applied.
> Your commit states that you add a new Kconfig to select the name of a
> file which is included in a generating a binary (which did not exist
> before )

This "new binary" is already generated on other platforms (e.g. MVEBU).
So its not introduced with this patch.
  
> So I see 2 changes: 1) new binary will be created from now on
> 2) to create this binary a new Kconfig is used which selects one of the
> files used to create it

I'll add that this "new binary" is now generated for AT91 & SPL_NAND.
Like this:

Makefile: Add Kconfig option CONFIG_SPL_IMAGE to select the SPL binary

This patch adds the CONFIG_SPL_IMAGE option to select the SPL image that
shall be used to generate the combined SPL + U-Boot image. The default
value is the current value "spl/u-boot-spl.bin".

This patch also sets CONFIG_SPL_IMAGE to "spl/boot.bin" for AT91 targets
which use SPL NAND support (boot from NAND). For these build targets the
combined image "u-boot-with-spl.bin" is now automatically generated and
can be programmed into NAND as one single image (vs. SPL image and U-Boot
as 2 separate images).


What do you think?

Thanks,
Stefan