[U-Boot] [PATCH 1/1] hush: provide help for 'if', 'for', and 'while'

[Heinrich Schuchardt]

On 3/29/19 1:11 PM, Wolfgang Denk wrote:
> Dear Heinrich,
>
> In message <20190329113408.2168-1-xypron.glpk at gmx.de> you wrote:
>> Provide online help for hush commands 'if', 'for', and 'while'.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> Why for these, and not for the rest of the shell syntax?

I missed one keyword "until" which I should add. But otherwise this
patch covers all keywords defined in cli_hush.c.

It does not cover logical expression (&&, ||) and comparisons.

>
> This does not make sense to me.  Shell syntax is way more complex
> than you can explain here.  In the end, you are just adding to the
> memory footprint for minimal (or no) advantage.

You could say the same for any online help. I do not understand why you
consider these commands not worth a description while we provide online
help for all other commands including "test", "echo", "help" and even "?".

Best regards

Heinrich

>
> I'm against adding this.
>
> Best regards,
>
> Wolfgang Denk
>