[U-Boot] [PATCH 1/1] hush: provide help for 'if', 'for', and 'while'

[Tom Rini]

On Fri, Mar 29, 2019 at 08:21:01PM +0100, Heinrich Schuchardt wrote:
> On 3/29/19 1:11 PM, Wolfgang Denk wrote:
> > Dear Heinrich,
> >
> > In message <20190329113408.2168-1-xypron.glpk at gmx.de> you wrote:
> >> Provide online help for hush commands 'if', 'for', and 'while'.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >
> > Why for these, and not for the rest of the shell syntax?
> 
> I missed one keyword "until" which I should add. But otherwise this
> patch covers all keywords defined in cli_hush.c.
> 
> It does not cover logical expression (&&, ||) and comparisons.
> 
> >
> > This does not make sense to me.  Shell syntax is way more complex
> > than you can explain here.  In the end, you are just adding to the
> > memory footprint for minimal (or no) advantage.
> 
> You could say the same for any online help. I do not understand why you
> consider these commands not worth a description while we provide online
> help for all other commands including "test", "echo", "help" and even "?".
> 
> Best regards
> 
> Heinrich
> 
> >
> > I'm against adding this.
> >
> > Best regards,
> >
> > Wolfgang Denk

Maybe a tiny bit more context is useful here.  Over at
https://stackoverflow.com/questions/55381641/how-to-test-the-return-of-a-command-in-u-boot-cli
Heinrich's initial answer was different as he didn't know we had 'if'
under HUSH_PARSER.  The initial poster also didn't have any idea on how
the syntax for 'if' worked for us.  That tells me there's probably other
folks out there that also don't know and we should provide a little
help.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190331/084ebcf6/attachment.sig>