[U-Boot] [PATCH 1/1] efi_loader: superfluous check in efi_remove_protocol()

Heinrich Schuchardt xypron.glpk at gmx.de
Fri May 10 18:02:00 UTC 2019


efi_search_protocol() already checks that the GUID matches. Don't check
a second time.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 lib/efi_loader/efi_boottime.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index a1fac60ee1..7263b2e0a7 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -513,8 +513,6 @@ efi_status_t efi_remove_protocol(const efi_handle_t handle,
 	ret = efi_search_protocol(handle, protocol, &handler);
 	if (ret != EFI_SUCCESS)
 		return ret;
-	if (guidcmp(handler->guid, protocol))
-		return EFI_INVALID_PARAMETER;
 	if (handler->protocol_interface != protocol_interface)
 		return EFI_INVALID_PARAMETER;
 	list_del(&handler->link);
--
2.20.1



More information about the U-Boot mailing list