[U-Boot] [PATCH] net: phy: ti: Fix clock output DT property

Grygorii Strashko grygorii.strashko at ti.com
Mon May 13 17:14:17 UTC 2019



On 10.05.19 20:49, Trent Piepho wrote:
> The code block reading the DT property for the clock output control was
> before the phy's DT node pointer was set, so it could never work.  Move
> it after the node pointer is set.
> 
> Also store the unsigned 32-bit property into an unsigned value, not a
> signed value, as the former will cause a problem if value overflows.
> For instance, if one were to add 0xffffffff as a code to mean the clock
> output should be turned off.
> 
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Janine Hagemann <j.hagemann at phytec.de>
> Cc: Grygorii Strashko <grygorii.strashko at ti.com>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>
> ---
>  drivers/net/phy/ti.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko at ti.com> 

-- 
Best regards,
grygorii


More information about the U-Boot mailing list