[U-Boot] White space cleanup
Wolfgang Denk
wd at denx.de
Fri Nov 8 16:55:03 UTC 2019
Dear Tom,
In message <20191108151810.GY19317 at bill-the-cat> you wrote:
>
> > When would be a good point of time in the release cycle to submit
> > such a patch series?
>
> Lets see. For '//' style comments, while I personally can't bring
> myself to use them, most of what we have today is generated files or
> external project files. Given that the Linux kernel no longer complains
> about it (and per the last thread about them, they're C99 comments, and
> that's 20 years ago now), it's probably best to just say they're
> discouraged but also that:
> writel(1, DDRPHY_CONFIG_BASE + 0x134); // DATA0_REG_PHY_USE_RANK0_DELAYS
> is at least as readable if not more so than:
> writel(1, DDRPHY_CONFIG_BASE + 0x134); /* DATA0_REG_PHY_USE_RANK0_DELAYS */
>
> which goes past 80 chars wide, rather than sticking to 80.
Agreed. I guess age brings that I also feel less fanatic here ;-)
> For the whitespace stuff, whenever is fine, being careful of stuff we
> sync from elsewhere rather than is our own. Whitespace changes there
> make future resync harder. Thanks!
Sure. But you did not answer my key question:
When would be a good point of time in the release cycle to submit
such a patch series?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price of curiosity is a terminal experience.
- Terry Pratchett, _The Dark Side of the Sun_
More information about the U-Boot
mailing list