[U-Boot] [PATCH] gpio: at91_gpio: Add bank names

[Eugen.Hristev at microchip.com]

On 19.11.2019 16:17, James Byrne wrote:
> 
> Hi Eugen,
> 
> On 18/11/2019 08:59, Eugen.Hristev at microchip.com wrote:
>>> @@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
>>>
>>>           clk_free(&clk);
>>>
>>> -       uc_priv->bank_name = plat->bank_name;
>>> -       uc_priv->gpio_count = GPIO_PER_BANK;
>>> -
>>>    #if CONFIG_IS_ENABLED(OF_CONTROL)
>>>           plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
>>>    #endif
>>> +       plat->bank_name = at91_get_bank_name(plat->base_addr);
>>
>> Hello James,
>>
>> Here you are rewriting the plat->bank_name... What was the old name that
>> comes from the platform struct ?
> 
> It was unset (null).

Ok. Can you make the default name go to something like 'undefined' 
instead of an empty string ?  Maybe it would be more meaningful, what do 
you think ? (and easier to spot in the CLI )

Thanks
> 
> Regards,
> 
> James
>