[U-Boot] [PATCH] gpio: at91_gpio: Add bank names

James Byrne james.byrne at origamienergy.com
Tue Nov 19 14:17:01 UTC 2019


Hi Eugen,

On 18/11/2019 08:59, Eugen.Hristev at microchip.com wrote:
>> @@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
>>
>>           clk_free(&clk);
>>
>> -       uc_priv->bank_name = plat->bank_name;
>> -       uc_priv->gpio_count = GPIO_PER_BANK;
>> -
>>    #if CONFIG_IS_ENABLED(OF_CONTROL)
>>           plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
>>    #endif
>> +       plat->bank_name = at91_get_bank_name(plat->base_addr);
> 
> Hello James,
> 
> Here you are rewriting the plat->bank_name... What was the old name that
> comes from the platform struct ?

It was unset (null).

Regards,

James


More information about the U-Boot mailing list