[U-Boot] [PATCH v3] spi: cadence_qspi: support DM_CLK

[Marek Vasut]

On 11/20/19 8:49 PM, Simon Goldschmidt wrote:
> Marek,
> 
> Am 12.11.2019 um 12:57 schrieb Simon Goldschmidt:
>> On Tue, Nov 12, 2019 at 12:40 PM Vignesh Raghavendra
>> wrote:
>>>
>>>
>>>
>>> On 12/11/19 4:57 PM, Simon Goldschmidt wrote:
>>>> On Tue, Nov 12, 2019 at 10:30 AM Tan, Ley Foon
>>>> <ley.foon.tan at intel.com> wrote:
>>>>>
>>> [...]
>>>>>>> But, unfortunately, such stub does not exists for clk_get_rate().
>>>>>>> So on platforms w/o CONFIG_CLK set:
>>>>>>>
>>>>>>> arm-linux-gnueabihf-ld.bfd: drivers/spi/built-in.o: in function
>>>>>> `cadence_spi_probe':
>>>>>>> /home/a0132425/workspace/u-boot/drivers/spi/cadence_qspi.c:184:
>>>>>> undefined reference to `clk_get_rate'
>>>>>>> Makefile:1647: recipe for target 'u-boot' failed
>>>>>>> make: *** [u-boot] Error 1
>>>>>>
>>>>>> So why did it compile for me? Probably because the linker knows it
>>>>>> doesn't
>>>>>> need 'clk_get_rate' since this branch will never be executed?
>>>>> Maybe you can try compile from clean build. Run "make mrproper"
>>>>> before compile.
>>>>
>>>> Of course I did that, and I just did it again. It *does* compile.
>>>>
>>>> Can anyone tell me a config/setup where it doesn't compile? Or does
>>>> this complain only come from reading the sources?
>>>>
>>>
>>> I see above error with k2g_evm_defconfig and compiler is:
>>
>> Ok, just tested that config and it works for me :-(
> 
> After having a successful travis run for this on top of
> u-boot-socfpga/master, could you take this and re-send the PR of last week?
> 
> Travis run is here:
> 
> https://travis-ci.org/goldsimon/u-boot/builds/614187977

Wait, so that PR was good all along ?

Also, can you just resend this one ?