[U-Boot] [PATCH 5/6] arm: dts: ls1028a: adds Ethernet switch node and its dependencies

[Alexandru Marginean]

Hi Michael,

On 11/24/2019 1:11 AM, Michael Walle wrote:
> Am 2019-11-22 02:36, schrieb Alex Marginean:
>> The definition follows the DSA binding in kernel and describes the 
>> switch,
>> its ports and PHYs.
>> ENETC PF6 is the 2nd Eth controller linked to the switch on LS1028, it is
> 
> nitpicking.. LS1028A
> 
> 
>> not used in U-Boot and was disabled.
> 
> it should be checked that the connected enetc port should be enabled. 
> otherwise this driver goes awry.

On LS1028A if mater Eth is disabled (ENETC PF2) there is a crash, I 
assume that's what you bumped into.  From the looks of it that's caused 
by a hardware issue.  For others reading this, the issue is making PCI 
PF5 (the switch) unable to use its internal MDIO registers if PF2 
(master Eth) is disabled.
I don't think I want to have switch driver code check on the ENETC 
functions, this should end up in a SoC erratum with the recommendation 
to have PF2 enabled when using the switch.

On other platforms having a master Eth disabled means traffic through 
the switch won't work, but should not crash U-Boot either, uclass code 
seems to be fine in that regard.

Thanks for the review and for the comments, I'll send a v2 for this series.

Alex


> 
> [snip]
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot