[PATCH 1/1] riscv: remove redundant logical constraint.
Bin Meng
bmeng.cn at gmail.com
Tue Aug 4 03:47:20 CEST 2020
On Tue, Aug 4, 2020 at 5:33 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
Please remove the ending period in the commit title
> After
>
> if (ret) return ret;
>
> we know that ret is zero. Don't check it again.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> arch/riscv/lib/andes_plic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/lib/andes_plic.c b/arch/riscv/lib/andes_plic.c
> index 5cf29df670..c2a8fe4d9e 100644
> --- a/arch/riscv/lib/andes_plic.c
> +++ b/arch/riscv/lib/andes_plic.c
> @@ -52,7 +52,7 @@ static int init_plic(void)
> if (ret)
> return ret;
>
> - if (ret == 0 && dev) {
> + if (dev) {
> ofnode_for_each_subnode(node, dev_ofnode(dev->parent)) {
> const char *device_type;
Reviewed-by: Bin Meng <bin.meng at windriver.com>
More information about the U-Boot
mailing list