[PATCH 1/1] riscv: fix building with CONFIG_SPL_SMP=n

[Bin Meng]

+Andy Shevchenko

On Tue, Aug 4, 2020 at 10:58 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 04.08.20 15:15, Bin Meng wrote:
> > On Tue, Aug 4, 2020 at 7:02 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>
> >> On 04.08.20 03:46, Bin Meng wrote:
> >>> On Tue, Aug 4, 2020 at 5:26 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>>>
> >>>> Building with CONFIG_SPL_SMP=n results in:
> >>>>
> >>>> arch/riscv/lib/spl.c: In function ‘jump_to_image_no_args’:
> >>>> arch/riscv/lib/spl.c:33:6:
> >>>> error: unused variable ‘ret’ [-Werror=unused-variable]
> >>>>    33 |  int ret;
> >>>>       |      ^~~
> >>>>
> >>>> Define the variable ret as __maybe_unused.
> >>>>
> >>>> Fixes: 191636e44898 ("riscv: Introduce SPL_SMP Kconfig option for U-Boot
> >>>> SPL")
> >>>
> >>> This should be on the same line
> >>
> >> Commit messages should not exceed 75 characters. See scripts/checkpatch.pl:
> >
> > True, for normal commit messages.
> >
> >>
> >> WARN("COMMIT_LOG_LONG_LINE",
> >> "Possible unwrapped commit description (prefer a maximum 75 chars per
> >> line)\n" . $herecurr);
> >>
> >
> > But this Fixes tag is special. I suspect 2 lines will break some
> > scripts that is handling this "Fixes" tag.
>
> checkpatch.pl and patchstream.py are the only U-Boot scripts containing
> the string "Fixes".
>
> * checkpatch.pl does not complain.
> * I don't use patman. So I don't care if it has a bug.
>
> We already have patches like this by other developers and nobody complained:

IIRC, last time Andy raised the same concern.

Andy, would you share some examples or best practices?

>
> dcdea292d9f3
> 4fb2264b2848
> 00160cf32e6e
>
> So why should I worry?
>

Regards,
Bin