sunxi/arm64 build broken (was: [PATCH v4 12/27] x86: Makefile: Drop explicit targets built by binman)

[Simon Glass]

Hi André,

On Wed, 5 Aug 2020 at 09:21, André Przywara <andre.przywara at arm.com> wrote:
>
> On 05/08/2020 16:05, Simon Glass wrote:
> > Hi André,
> >
> > On Wed, 5 Aug 2020 at 08:20, André Przywara <andre.przywara at arm.com> wrote:
> >>
> >> On 19/07/2020 20:56, Simon Glass wrote:
> >>
> >> Hi,
> >>
> >>> On x86 various files that need to be created by binman. It does not make
> >>> sense to enumerate these in the Makefile. They are described in the
> >>> configuration (devicetree) for each board and we can simply run binman
> >>> (always) to generate them.
> >>>
> >>> Update the Makefile to have a separate, final step which runs binman,
> >>> once all input dependencies are present.
> >>>
> >>> This avoid sprinkling the Makefile with arch-specific code.
> >>
> >> it seems that this patch (committed as 42b18df80fdb) breaks sunxi(!).
> >> When building current master, the Trusted Firmware binary does not make
> >> it into the u-boot-sunxi-with-spl.bin file. U-Boot still runs, but Linux
> >> won't get very far without BL31. To me it looks like we combine
> >> u-boot.img with the SPL, instead of u-boot.itb. Only the latter contains
> >> bl31.bin.
> >>
> >> I bisected down into the hunks of this patch here, and by reverting just
> >> hunk #3 (the one introducing .binman_stamp) it works again.
> >> My knowledge of the U-Boot build system is somewhat limited, so I don't
> >> immediately see the problem or a fix.
> >>
> >> A simple way to verify a build is complete would be:
> >> $ strings u-boot-sunxi-with-spl.bin | grep BL31
> >> If it reports some lines, TF-A is included and it would work correctly.
> >> If it comes back empty, TF-A is missing and we won't boot.
> >>
> >> I would be grateful for any insights!
> >
> > Thanks for the info. Which board is this?
>
> I happened to see this on bananapi_m64_defconfig, but any arm64 sunxi
> board should be affected.

OK thanks, will try that. The problem is not obvious to me but I'll
take another look before the end of today.

Regards,
SImon