[PATCH] Makefile: sunxi: Don't use binman to build ATF image

André Przywara andre.przywara at arm.com
Fri Aug 7 18:24:13 CEST 2020


On 07/08/2020 16:44, Simon Glass wrote:
> At present with sunxi 64-bit, the Makefile builds
> u-boot-sunxi-with-spl.bin and then binman overwrites it with its own
> version. But the binman definition lacks some parts, in particular
> BL31.
> 
> For now, work around this with a hack.

Many thanks for providing this! Indeed it fixes the immediate problem
for me. Tested on BananaPi-M64. Also compared the binaries for a 32-bit
BPi-M1 build with and w/o the fix, and found them identical (with
reproducible build magic).

> Signed-off-by: Simon Glass <sjg at chromium.org>

Tested-by: Andre Przywara <andre.przywara at arm.com>

Cheers,
Andre

> Fixes: 42b18df80fd ("x86: Makefile: Drop explicit targets built by binman")
> ---
> 
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 2629a741f1e..4483a9bc8a3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1024,9 +1024,13 @@ PHONY += inputs
>  inputs: $(INPUTS-y)
>  
>  all: .binman_stamp inputs
> +	# Hack for sunxi which doesn't have a proper binman definition for
> +	# 64-bit boards
> +ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
>  ifeq ($(CONFIG_BINMAN),y)
>  	$(call if_changed,binman)
>  endif
> +endif
>  
>  # Timestamp file to make sure that binman always runs
>  .binman_stamp: FORCE
> 



More information about the U-Boot mailing list