[PATCH] test: efi_selftest: Do not force serial# setting

Heinrich Schuchardt xypron.debian at gmx.de
Fri Aug 7 21:34:06 CEST 2020

On 7/31/20 11:42 PM, Tom Rini wrote:
> On Fri, Jul 31, 2020 at 10:12:32AM -0400, Tom Rini wrote:
>> As part of the EFI self test we set and check the serial# variable.
>> However, we should not be forcing this setting.  In the case where we
>> are allowed to change the variable it will change, and we will pass the
>> test.  In the case where we cannot change it, force may or may not be
>> allowed, depending on further environment restrictions.  Drop the -f
>> flag here as we do not need it.
>> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> Signed-off-by: Tom Rini <trini at konsulko.com>
> Applied to u-boot/master, thanks!

With this patch on the Pine64 LTS:

=> => setenv efi_selftest device tree
=> => setenv serial# Testing DT
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1

This worked without your patch.

This patch does not solve any problem.

Best regards


More information about the U-Boot mailing list