[PATCH v4 6/6] test/py: Add tests for the SquashFS commands

[Joao Marcos Costa]

Hello!

On Sat, 8 Aug 2020 10:41:38 -0400
Tom Rini <trini at konsulko.com> wrote:

> On Sat, Aug 08, 2020 at 08:31:06AM -0400, Tom Rini wrote:
> > On Thu, Jul 30, 2020 at 03:33:52PM +0200, Joao Marcos Costa wrote:
> >   
> > > Add Python scripts to test 'ls' and 'load' commands. The scripts
> > > generate a SquashFS image and clean the directory after the
> > > assertions, or if an exception is raised.
> > > 
> > > Signed-off-by: Joao Marcos Costa <joaomarcos.costa at bootlin.com>  
> > 
> > Applied to u-boot/master, thanks!  
> 
> But... CI got backed up and I missed a real failure.  Over at
> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=1053&view=logs&j=50449d1b-398e-53ae-48fa-6bf338edeb51&t=97605dd2-f5a5-5dd7-2118-315ffdc8bcd6&l=558
> the problem is:
> >       os.mkdir(src)  
> E       PermissionError: [Errno 13] Permission denied:
> 'test/py/tests/test_fs/test_squashfs/sqfs_src/'
> 
> because our source directory is read-only.  I believe you need to use
> cons.config.build_dir instead to get to our build directory.  Both
> tests fail in this manner.  Can you please confirm my suggestion
> fixes this? If you don't want to configure Azure support directly you
> can submit a PR against the github mirror and that in turn will
> trigger an Azure run you can follow.  Thanks!

I submitted the PR that applies your suggestion and it really
solves the problem. Here is the link to the log:
https://travis-ci.org/github/u-boot/u-boot/jobs/716488309#L1307

I will send the patch in a few minutes. Thanks!

> 
> > 
> > -- 
> > Tom  
> 
> 
> 

Joao Marcos