[PATCH] Makefile: fix annoying sunxi hack message

Tom Rini trini at konsulko.com
Wed Aug 12 14:00:14 CEST 2020


On Wed, Aug 12, 2020 at 01:48:33PM +0200, Michal Simek wrote:
> 
> 
> On 12. 08. 20 13:41, Tom Rini wrote:
> > On Wed, Aug 12, 2020 at 09:59:15AM +0200, Michal Simek wrote:
> >> út 11. 8. 2020 v 17:33 odesílatel Tom Rini <trini at konsulko.com> napsal:
> >>>
> >>> On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:
> >>>
> >>>> From: Frank Wunderlich <frank-w at public-files.de>
> >>>>
> >>>> every compilation shows this error
> >>>>
> >>>>  Hack for sunxi which doesn't have a proper binman definition for
> >>>>  64-bit boards
> >>>>
> >>>> not only for sunxi-boards/arm64
> >>>>
> >>>> fix this by changing to real comments
> >>>>
> >>>> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> >>>> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> >>>> ---
> >>>>  Makefile | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/Makefile b/Makefile
> >>>> index 4483a9bc8a..75c2987405 100644
> >>>> --- a/Makefile
> >>>> +++ b/Makefile
> >>>> @@ -1024,8 +1024,8 @@ PHONY += inputs
> >>>>  inputs: $(INPUTS-y)
> >>>>
> >>>>  all: .binman_stamp inputs
> >>>> -     # Hack for sunxi which doesn't have a proper binman definition for
> >>>> -     # 64-bit boards
> >>>> +# Hack for sunxi which doesn't have a proper binman definition for
> >>>> +# 64-bit boards
> >>>>  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
> >>>>  ifeq ($(CONFIG_BINMAN),y)
> >>>>       $(call if_changed,binman)
> >>>
> >>> Um, what environment is this failing on?  Thanks!
> >>
> >> I also see this message when I build stuff for zynqmp.
> > 
> > Interesting, are you also on make 4.2 ?
> 
> I am on 4.1.

Ugh.  I'll apply the patch shortly as clearly we need it.  But I don't
see why it's failing in some places and not others, which is worrying.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/e7c3dba8/attachment.sig>


More information about the U-Boot mailing list