[PATCH 2/2] board: armltd: Add support for Total Compute platform

Usama Arif usama.arif at arm.com
Wed Aug 12 16:12:41 CEST 2020



On 12/08/2020 13:40, Tom Rini wrote:
> On Tue, Aug 11, 2020 at 03:46:04PM +0100, Usama Arif wrote:
> 
>> Total Compute is based on ARM architecture and has
>> the following features enabled in u-boot:
>> - PL011 UART
>> - PL180 MMC
>> - NOR Flash
>> - FIT image with Signature
>> - AVB
>>
>> Signed-off-by: Usama Arif <usama.arif at arm.com>
> [snip]
>> diff --git a/board/armltd/total_compute/MAINTAINERS b/board/armltd/total_compute/MAINTAINERS
>> new file mode 100644
>> index 0000000000..7c653d469a
>> --- /dev/null
>> +++ b/board/armltd/total_compute/MAINTAINERS
>> @@ -0,0 +1,6 @@
>> +TOTAL_COMPUTE BOARD
>> +M:	Usama Arif <usama.arif at arm.com>
>> +S:	Maintained
>> +F:	board/armltd/total_compute/
>> +F:	include/configs/total_compute.h
>> +F:	configs/total_compute_defconfig
> 
> Please list the dtb files as well here.
> 
>> +#define CONFIG_EXTRA_ENV_SETTINGS	\
>> +				"load_addr=0xa0000000\0"	\
>> +				"kernel_addr_r=0x80080000\0"	\
>> +				"initrd_addr_r=0x88000000\0"	\
>> +				"fdt_addr_r=0x83000000\0"	\
>> +				"fdt_high=0xffffffffffffffff\0"	\
>> +				"initrd_high=0xffffffffffffffff\0"
>> +
> 
> Disabling fdt/initrd relocation is wrong.  Please set bootm_size as
> needed if fdt/initrd need to be relocated to within a window of memory
> rather than all available.  Thanks!
> 

Hi,

Thanks for the review.

I have submitted a v2 version of the patch with 
arch/arm/dts/total_compute.dts addded to 
board/armltd/total_compute/MAINTAINERS and a bootm_size of 512 MB.

Thanks,
Usama


More information about the U-Boot mailing list