[PATCH v2] board: armltd: Add support for Total Compute platform

Usama Arif usama.arif at arm.com
Wed Aug 12 17:11:07 CEST 2020



On 12/08/2020 15:53, Tom Rini wrote:
> On Wed, Aug 12, 2020 at 03:08:14PM +0100, Usama Arif wrote:
>> Total Compute is based on ARM architecture and has
>> the following features enabled in u-boot:
>> - PL011 UART
>> - PL180 MMC
>> - NOR Flash
>> - FIT image with Signature
>> - AVB
>>
>> Signed-off-by: Usama Arif <usama.arif at arm.com>
>> ---
>> Changes for v2:
>>   - Added arch/arm/dts/total_compute.dts to board/armltd/total_compute/MAINTAINERS
>>   - Added bootm_size of 512 MB for total compute board.
> [snip]
>> +#define CONFIG_EXTRA_ENV_SETTINGS	\
>> +				"bootm_size=0x20000000\0"	\
>> +				"load_addr=0xa0000000\0"	\
>> +				"kernel_addr_r=0x80080000\0"	\
>> +				"initrd_addr_r=0x88000000\0"	\
>> +				"fdt_addr_r=0x83000000\0"	\
>> +				"fdt_high=0xffffffffffffffff\0"	\
>> +				"initrd_high=0xffffffffffffffff\0"
> 
> You need to drop fdt_high/initrd_high too as that's disabling relocation
> and that is almost never the right choice.  Thanks!
> 

Removed fdt_high and initrd_high in v3 to allow relocation. Thanks again 
for the review.

Usama


More information about the U-Boot mailing list