[PATCH v2 03/21] clk: bind clk to new parent device

Simon Glass sjg at chromium.org
Sun Aug 16 05:39:29 CEST 2020


Hi Claudiu,

On Thu, 6 Aug 2020 at 02:24, <Claudiu.Beznea at microchip.com> wrote:
>
> Hi Simon,
>
> On 05.08.2020 18:11, Claudiu Beznea wrote:
> > Clock re-parenting is not binding the clock's device to its new
> > parent device, it only calls the clock's ops->set_parent() API. The
> > changes in this commit re-parent the clock device to its new parent
> > so that subsequent operations like clk_get_parent() to point to the
> > proper parent.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea at microchip.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> I added your Reviewed-by here but at the same time I also added the sandbox
> test in this patch. Let me know if you want the sandbox test in a separate
> patch. Same thing for patch 4/21 in this series.

I think it is nice to have the test in the same patch in many cases,
since it clearly shows that there is a test for the change / new
functionality.

Regards,
Simon


More information about the U-Boot mailing list