[PATCH] net: smc911x: Automatically Update ethaddr with MAC

Adam Ford aford173 at gmail.com
Mon Aug 17 16:51:05 CEST 2020


On Mon, Aug 17, 2020 at 9:41 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Aug 16, 2020 at 07:17:37AM -0500, Adam Ford wrote:
>
> > The ethernet controller can read the MAC from EEPROM and display it,
> > but if ethaddr is not set, the ethernet is still unavailable.
> >
> > This patch checks will automatically set the MAC address if it has
> > not already been set.
> >
> > Signed-off-by: Adam Ford <aford173 at gmail.com>
> >
> > diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> > index 9c5dc46483..f028bfba18 100644
> > --- a/drivers/net/smc911x.c
> > +++ b/drivers/net/smc911x.c
> > @@ -6,6 +6,7 @@
> >   */
> >
> >  #include <common.h>
> > +#include <env.h>
> >  #include <command.h>
> >  #include <malloc.h>
> >  #include <net.h>
> > @@ -185,6 +186,8 @@ static void smc911x_handle_mac_address(struct smc911x_priv *priv)
> >       smc911x_set_mac_csr(priv, ADDRH, addrh);
> >
> >       printf(DRIVERNAME ": MAC %pM\n", m);
> > +     if (!env_get("ethaddr"))
> > +             env_set("fdt_file", (const char *)m);
>
> Um, clearly a thinko here and you meant ethaddr and not fdt_file? :)

You are right.  (facepalm, egg on my face)

I'll submit a V2 later today.

adam
>
> --
> Tom


More information about the U-Boot mailing list