[PATCH v6 03/10] board_f: Add default values for bi_dram[] in dram_init_banksize()

Ovidiu Panait ovidiu.panait at windriver.com
Mon Aug 17 19:39:06 CEST 2020


On 17.08.2020 09:48, Stefan Roese wrote:

> Remove the bi_memstart / bi_memsize assignment in setup_bdinfo() and
> make sure, that bd_dram[] is always configured in the weak default
> implementation of dram_init_banksize(), when CONFIG_SYS_SDRAM_BASE is
> not set.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
>
> ---
>
> Changes in v6:
> - Simplify dram_init_banksize() even more as suggested by Daniel
>
> Changes in v4:
> - New patch
>
>   common/board_f.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index d1f0f9af08..8a43df97e4 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -237,10 +237,8 @@ static int show_dram_config(void)
>   
>   __weak int dram_init_banksize(void)
>   {
> -#if defined(CONFIG_SYS_SDRAM_BASE)
> -	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
> +	gd->bd->bi_dram[0].start = gd->ram_base;
>   	gd->bd->bi_dram[0].size = get_effective_memsize();
> -#endif
>   
>   	return 0;
>   }
> @@ -602,9 +600,6 @@ int setup_bdinfo(void)
>   {
>   	struct bd_info *bd = gd->bd;
>   
> -	bd->bi_memstart = gd->ram_base;  /* start of memory */
> -	bd->bi_memsize = gd->ram_size;   /* size in bytes */
> -
>   	if (IS_ENABLED(CONFIG_SYS_HAS_SRAM)) {
>   		bd->bi_sramstart = CONFIG_SYS_SRAM_BASE; /* start of SRAM */
>   		bd->bi_sramsize = CONFIG_SYS_SRAM_SIZE;  /* size  of SRAM */
Reviewed-by: Ovidiu Panait <ovidiu.panait at windriver.com>


More information about the U-Boot mailing list