[PATCH v3 1/4] fs/squashfs: Add init. and clean-up functions to decompression

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Aug 18 16:34:24 CEST 2020


In your commit title: spurious . after "init".

On Tue, 18 Aug 2020 16:31:15 +0200
Joao Marcos Costa <joaomarcos.costa at bootlin.com> wrote:

> -static struct squashfs_ctxt ctxt;
> +struct squashfs_ctxt sqfs_ctxt;

Why are you dropping the "static" here ? This symbol only needs to be
visible from that file. If you keep the "static" keyword, you can keep
the variable named "ctxt" and avoid a lengthy patch.

> +	ret = sqfs_decompressor_init(&sqfs_ctxt);

See you're passing a reference to the squashfs context here, so this
variable does not need to be visible by other files.

Best regards,

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering

More information about the U-Boot mailing list