[PATCH v4 1/5] fs/squashfs: Add init and clean-up functions to decompression

[Thomas Petazzoni]

Hello,

On Tue, 18 Aug 2020 17:17:21 +0200
Joao Marcos Costa <joaomarcos.costa at bootlin.com> wrote:

> Add sqfs_decompressor_init() and sqfs_decompressor_cleanup(). These
> functions are called respectively in sqfs_probe() and sqfs_close(). For
> now, only ZSTD requires an initialization logic. ZSTD support will be
> added in a follow-up commit.
> 
> Move squashfs_ctxt definition to sqfs_filesystem.h. This structure is
> passed to sqfs_decompressor_init() and sqfs_decompressor_cleanup(), so
> it can no longer be local to sqfs.c.
> 
> Signed-off-by: Joao Marcos Costa <joaomarcos.costa at bootlin.com>

Thanks, looks better. One small nit, though.

>  #if IS_ENABLED(CONFIG_ZLIB)
>  static void zlib_decompression_status(int ret)
>  {
> @@ -35,14 +63,14 @@ static void zlib_decompression_status(int ret)
>  #endif
>  
>  int sqfs_decompress(u16 comp_type, void *dest, unsigned long *dest_len,
> -		    void *source, u32 lenp)
> +		    void *source, u32 src_len)
>  {
>  	int ret = 0;
>  
>  	switch (comp_type) {
>  #if IS_ENABLED(CONFIG_ZLIB)
>  	case SQFS_COMP_ZLIB:
> -		ret = uncompress(dest, dest_len, source, lenp);
> +		ret = uncompress(dest, dest_len, source, src_len);

These two changes are not related to this patch.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com