[PATCH 2/9] cmd: Kconfig: Add missing dependency for cmd gpt

Heinrich Schuchardt xypron.glpk at gmx.de
Wed Aug 19 10:46:57 CEST 2020


On 19.08.20 10:44, Michal Simek wrote:
> Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is
> doesn't need to be enabled.
>
> Kconfig reports it like this.
>
> WARNING: unmet direct dependencies detected for PARTITION_UUIDS
>   Depends on [n]: PARTITIONS [=n]
>   Selected by [y]:
>   - CMD_GPT [=y]
>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 9ad511aa176f..692fae5b8e89 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1012,6 +1012,7 @@ config CMD_GPT
>  	bool "GPT (GUID Partition Table) command"
>  	select EFI_PARTITION
>  	select HAVE_BLOCK_DEVICE
> +	select PARTITIONS
>  	select PARTITION_UUIDS

It would be preferable to use "depends" instead of "select".

You don't want anybody to select this command on a device that does not
even have block devices.

Best regards

Heinrich


>  	imply RANDOM_UUID
>  	help
>



More information about the U-Boot mailing list