[PATCH v3 2/8] usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses

Bin Meng bmeng.cn at gmail.com
Fri Aug 21 08:27:30 CEST 2020


On Fri, Aug 21, 2020 at 1:34 PM Stefan Roese <sr at denx.de> wrote:
>
> Octeon uses mapped addresses for virtual and physical memory. It's not
> that easy to calculate the resulting addresses here. So let's remove
> this BUG_ON() completely, as it's not really helpful.
>
> Please also note, that BUG_ON() is not recommended any more in the Linux
> kernel.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: Marek Vasut <marex at denx.de>
>
> ---
>
> Changes in v3:
> - Minor corrections to the commit text as suggested by Bin
>
> Changes in v2:
> - Completely remove BUG_ON() for this trans_event.buffer check
> - Reword commit text
>
>  drivers/usb/host/xhci-ring.c | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list