[PATCH] board/freescale/common: emc2305: Pass chip_addr to set_fan_speed()

Wasim Khan wasim.khan at nxp.com
Fri Aug 21 22:50:27 CEST 2020


emc2305 is a common driver. It should not use platform specific
i2c address for slave device.
Pass chip_addr as agrument to set_fan_speed() so that emc2305 driver
can be used with different platforms.

Signed-off-by: Wasim Khan <wasim.khan at nxp.com>
---
 board/freescale/common/emc2305.c  | 9 ++++-----
 board/freescale/common/emc2305.h  | 5 ++---
 board/freescale/lx2160a/lx2160a.c | 2 +-
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/board/freescale/common/emc2305.c b/board/freescale/common/emc2305.c
index b1ca051..7dd49c5 100644
--- a/board/freescale/common/emc2305.c
+++ b/board/freescale/common/emc2305.c
@@ -1,8 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Copyright 2018 NXP.
+ * Copyright 2018-2020 NXP.
  *
- * SPDX-License-Identifier:     GPL-2.0+
  */
 
 #include <common.h>
@@ -14,7 +13,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-void set_fan_speed(u8 data)
+void set_fan_speed(u8 data, int chip_addr)
 {
 	u8 index;
 	u8 Fan[NUM_OF_FANS] = {I2C_EMC2305_FAN1,
@@ -25,14 +24,14 @@ void set_fan_speed(u8 data)
 
 	for (index = 0; index < NUM_OF_FANS; index++) {
 #ifndef CONFIG_DM_I2C
-		if (i2c_write(I2C_EMC2305_ADDR, Fan[index], 1, &data, 1) != 0) {
+		if (i2c_write(chip_addr, Fan[index], 1, &data, 1) != 0) {
 			printf("Error: failed to change fan speed @%x\n",
 			       Fan[index]);
 		}
 #else
 		struct udevice *dev;
 
-		if (i2c_get_chip_for_busnum(0, I2C_EMC2305_ADDR, 1, &dev))
+		if (i2c_get_chip_for_busnum(0, chip_addr, 1, &dev))
 			continue;
 
 		if (dm_i2c_write(dev, Fan[index], &data, 1) != 0) {
diff --git a/board/freescale/common/emc2305.h b/board/freescale/common/emc2305.h
index eddf537..f730c49 100644
--- a/board/freescale/common/emc2305.h
+++ b/board/freescale/common/emc2305.h
@@ -1,8 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0+ */
 /*
- * Copyright 2018 NXP
+ * Copyright 2018-2020 NXP
  *
- * SPDX-License-Identifier:     GPL-2.0+
  */
 
 #ifndef __EMC2305_H_
@@ -18,6 +17,6 @@
 #define NUM_OF_FANS			5
 
 void emc2305_init(void);
-void set_fan_speed(u8 data);
+void set_fan_speed(u8 data, int chip_addr);
 
 #endif  /* __EMC2305_H_ */
diff --git a/board/freescale/lx2160a/lx2160a.c b/board/freescale/lx2160a/lx2160a.c
index ace2a19..06c00ea 100644
--- a/board/freescale/lx2160a/lx2160a.c
+++ b/board/freescale/lx2160a/lx2160a.c
@@ -115,7 +115,7 @@ int board_early_init_f(void)
 #ifdef CONFIG_EMC2305
 	select_i2c_ch_pca9547(I2C_MUX_CH_EMC2305);
 	emc2305_init();
-	set_fan_speed(I2C_EMC2305_PWM);
+	set_fan_speed(I2C_EMC2305_PWM, I2C_EMC2305_ADDR);
 	select_i2c_ch_pca9547(I2C_MUX_CH_DEFAULT);
 #endif
 
-- 
2.7.4



More information about the U-Boot mailing list