[PATCH v2 5/5] xen: Code style conformity

Tom Rini trini at konsulko.com
Tue Aug 25 14:17:44 CEST 2020


On Fri, Aug 21, 2020 at 12:10:04PM +0300, Anastasiia Lukianenko wrote:

> From: Anastasiia Lukianenko <anastasiia_lukianenko at epam.com>
> 
> Cleaning up the following:
> 
> ERROR: do not use assignment in if condition
> #281: FILE: drivers/xen/pvblock.c:260:
> +       if ((err = xenbus_switch_state(XBT_NIL, nodename,
> CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err"
> #52: FILE: drivers/xen/pvblock.c:298:
> +       if (err != NULL) {
> ERROR: do not use assignment in if condition
> #176: FILE: drivers/xen/gnttab.c:103:
> +               if ((flags = nflags) & (GTF_reading | GTF_writing)) {
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #329: FILE: include/xen/gnttab.h:1:
> +/*
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #330: FILE: include/xen/gnttab.h:2:
> + * SPDX-License-Identifier: GPL-2.0
> ERROR: do not use assignment in if condition
> #630: FILE: lib/sscanf.c:558:
> +                               if ((n = inr) < width) {
> 
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko at epam.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/7d21a1f3/attachment.sig>


More information about the U-Boot mailing list