[PATCH] fastboot: getvar: fix partition-size return value
gary.bisson at boundarydevices.com
Thu Aug 27 09:46:24 CEST 2020
On Thu, Aug 27, 2020 at 08:25:51AM +0200, Lukasz Majewski wrote:
> Hi Gary,
> > Hi Lukasz,
> > On Wed, Aug 26, 2020 at 11:36:51AM +0200, Lukasz Majewski wrote:
> > > Hi Gary,
> > >
> > > > Hi,
> > > >
> > > > Gentle ping on this patch. Hopefully Sam's email won't bounce this
> > > > time.
> > >
> > > You couldn't have better timing than now :-)
> > >
> > > I'm now testing PR for Tom  and your original patch was causing
> > > some issues (probably it was correct when it was posted, but it was
> > > my fault that I'm going to pull it in now - my apologizes).
> > >
> > > I've fixed it  - please check if this fix is OK.
> > Actually it was wrong before too, thanks for catching it!
> > Reason is that I didn't build with FASTBOOT_FLASH_NAND config enabled
> > which I should have done to check the second part of the change...
> Ok. I've found another issue with this patch - it has some issues with
> drivers/fastboot/fb_getvar.c: In function 'getvar_get_part_info':
> +drivers/fastboot/fb_getvar.c:118:38: error: 'struct part_info' has no
> member named 'blksz'
> + 118 | *size = part_info->size * part_info->blksz;
> + | ^~
> +make: *** [drivers/fastboot/fb_getvar.o] Error 1
> The whole CI run can be found here:
Thanks, I'll take a look.
> > > Now I'm hunting another issues with sandbox . When fixed I will
> > > send the PR.
> > Sounds good. Let me know if you need anything from me.
> I think that the best solution would be if I drop this patch from
> the series and send PR (after some CI testing) without it. If you
> manage to fix it ASAP, then I will pull it immediately.
Sure let's do this, drop my patch for now, I'll re-submit when possible.
More information about the U-Boot