[PATCH] common: Kconfig: Add dependency for default variables strings

Tom Rini trini at konsulko.com
Thu Aug 27 17:16:30 CEST 2020


On Wed, Aug 12, 2020 at 09:28:24AM +0200, Michal Simek wrote:

> Kconfig provides several config options for setting up default variables
> but these are unused when variables are passed to U-Boot via file.
> That's why cover this dependency in Kconfig.
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
> 
> There are likely other Kconfig entries which should be fixed too.
> 
> ---
>  common/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 62d78c5bd739..b7d5a8f28cf8 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -355,7 +355,7 @@ endmenu
>  config BOOTDELAY
>  	int "delay in seconds before automatically booting"
>  	default 2
> -	depends on AUTOBOOT
> +	depends on AUTOBOOT && !USE_DEFAULT_ENV_FILE
>  	help
>  	  Delay before automatically running bootcmd;
>  	  set to 0 to autoboot with no delay, but you can stop it by key input.

The rest are fine but BOOTDELAY is used directly in the code outside of
just the environment.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200827/e67c67d4/attachment.sig>


More information about the U-Boot mailing list