[PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return value

Peng Fan peng.fan at nxp.com
Fri Aug 28 07:37:47 CEST 2020


> Subject: [PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return
> value
> 
> clk_set_rate will return rate in case of success and zero in case of error,
> however it can also return -ev, but it's an ulong function.
> To avoid any issues, disregard the return value of this call.
> In case this call actually fails, nothing much we can do anyway, but we can at
> least try with the previous values (or DT assigned-clocks)
> 
> Signed-off-by: Eugen Hristev <eugen.hristev at microchip.com>
> ---
>  drivers/mmc/atmel_sdhci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/atmel_sdhci.c b/drivers/mmc/atmel_sdhci.c index
> f03c0457e1..54b660c34a 100644
> --- a/drivers/mmc/atmel_sdhci.c
> +++ b/drivers/mmc/atmel_sdhci.c
> @@ -79,9 +79,7 @@ static int atmel_sdhci_probe(struct udevice *dev)
>  	if (ret)
>  		return ret;
> 
> -	ret = clk_set_rate(&clk, ATMEL_SDHC_GCK_RATE);
> -	if (ret)
> -		return ret;
> +	clk_set_rate(&clk, ATMEL_SDHC_GCK_RATE);
> 
>  	max_clk = clk_get_rate(&clk);
>  	if (!max_clk)

Since clk_set_rate will return the new rate or 0, is there
a need to use clk_get_rate following there?

Regards,
Peng.


> --
> 2.25.1



More information about the U-Boot mailing list