[PATCHv4 00/16] powerpc: covert p1010, p1020 and p2020 RDB board to DM_ETH

Z.q. Hou zhiqiang.hou at nxp.com
Thu Jul 2 04:09:38 CEST 2020


Hi Vladimir,

Thanks a lot for your comments!

> -----Original Message-----
> From: Vladimir Oltean [mailto:olteanv at gmail.com]
> Sent: 2020年7月2日 1:46
> To: Z.q. Hou <zhiqiang.hou at nxp.com>
> Cc: u-boot <u-boot at lists.denx.de>; Bin Meng <bmeng.cn at gmail.com>;
> Priyanka Jain <priyanka.jain at nxp.com>
> Subject: Re: [PATCHv4 00/16] powerpc: covert p1010, p1020 and p2020 RDB
> board to DM_ETH
> 
> On Wed, 1 Jul 2020 at 20:11, Vladimir Oltean <olteanv at gmail.com> wrote:
> >
> > Hi Zhiqiang,
> >
> > On Wed, 1 Jul 2020 at 20:05, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote:
> > >
> > > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > >
> > > This patch set depends on:
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > >
> tchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20200503185227.2873
> 1-
> > >
> 2-olteanv%40gmail.com%2F&data=02%7C01%7CZhiqiang.Hou%40nxp.c
> om%7
> > >
> C9215a1fed74348210eb108d81de69d85%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635
> > > %7C0%7C0%7C637292223605570364&sdata=s1fe6AFATwaeeUAOU
> gK7vMElVZNP
> > > 3L%2F62pDsdcfOE%2BY%3D&reserved=0
> > >
> > > Hou Zhiqiang (16):
> > >   net: fsl_mdio: Change to use virtual address
> > >   net: fsl_mdio: Correct the MII management register block address
> > >   net: tsec: convert to use DM_MDIO when DM_ETH enabled
> > >   net: tsec: Add fixed-link PHY support
> > >   net: tsec: Add the compatible string "gianfar" support
> > >   powerpc: mpc8xxx: Don't compile cpu_eth_init() when DM_ETH
> enabled
> > >   fsl: p1_p2_rdb: Move vsc7835 firmware uploading to
> > >     board_early_init_r()
> > >   configs: p1_p2_rdb: Add the default address of vsc7385 firmware
> > >   dts: powerpc: p1020rdb: Add eTSEC DT nodes
> > >   powerpc: p1_p2_rdb: Don't compile board_eth_init() when DM_ETH
> enabled
> > >   configs: P1020RDB: Enable DM_ETH config
> > >   dts: powerpc: p1010rdb: Add eTSEC DT nodes
> > >   powerpc: p1010rdb: Compile legacy ethernet init function when no
> > >     DM_ETH
> > >   configs: P1010RDB: Enable DM_ETH config
> > >   dts: powerpc: p2020rdb: Add eTSEC DT nodes
> > >   configs: P2020RDB: Enable DM_ETH config
> > >
> > >  arch/powerpc/cpu/mpc8xxx/cpu.c                |  2 +
> > >  arch/powerpc/dts/p1010rdb-pa.dts              |  1 +
> > >  arch/powerpc/dts/p1010rdb-pa_36b.dts          |  1 +
> > >  arch/powerpc/dts/p1010rdb.dtsi                | 50
> +++++++++++++++
> > >  arch/powerpc/dts/p1010si-post.dtsi            | 25 ++++++++
> > >  arch/powerpc/dts/p1020-post.dtsi              | 20 +++++-
> > >  arch/powerpc/dts/p1020rdb-pc.dts              |  1 +
> > >  arch/powerpc/dts/p1020rdb-pc.dtsi             | 55
> ++++++++++++++++
> > >  arch/powerpc/dts/p1020rdb-pc_36b.dts          |  1 +
> > >  arch/powerpc/dts/p1020rdb-pd.dts              | 45
> ++++++++++++++
> > >  arch/powerpc/dts/p2020-post.dtsi              | 10 ++-
> > >  arch/powerpc/dts/p2020rdb-pc.dts              |  1 +
> > >  arch/powerpc/dts/p2020rdb-pc.dtsi             | 50
> +++++++++++++++
> > >  arch/powerpc/dts/p2020rdb-pc_36b.dts          |  1 +
> > >  arch/powerpc/dts/pq3-etsec1-0.dtsi            | 28 +++++++++
> > >  arch/powerpc/dts/pq3-etsec1-1.dtsi            | 28 +++++++++
> > >  arch/powerpc/dts/pq3-etsec1-2.dtsi            | 28 +++++++++
> > >  arch/powerpc/dts/pq3-etsec1-3.dtsi            | 28 +++++++++
> > >  arch/powerpc/dts/pq3-etsec2-0.dtsi            | 35 +++++++++++
> > >  arch/powerpc/dts/pq3-etsec2-1.dtsi            | 35 +++++++++++
> > >  arch/powerpc/dts/pq3-etsec2-2.dtsi            | 35 +++++++++++
> > >  arch/powerpc/dts/pq3-etsec2-grp2-0.dtsi       | 16 +++++
> > >  arch/powerpc/dts/pq3-etsec2-grp2-1.dtsi       | 16 +++++
> > >  arch/powerpc/dts/pq3-etsec2-grp2-2.dtsi       | 16 +++++
> > >  board/freescale/p1010rdb/p1010rdb.c           |  2 +
> > >  board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c   | 37 ++++++-----
> > >  configs/P1010RDB-PA_36BIT_NAND_defconfig      |  2 +
> > >  configs/P1010RDB-PA_36BIT_NOR_defconfig       |  2 +
> > >  configs/P1010RDB-PA_36BIT_SDCARD_defconfig    |  2 +
> > >  configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig  |  2 +
> > >  configs/P1010RDB-PA_NAND_defconfig            |  2 +
> > >  configs/P1010RDB-PA_NOR_defconfig             |  2 +
> > >  configs/P1010RDB-PA_SDCARD_defconfig          |  2 +
> > >  configs/P1010RDB-PA_SPIFLASH_defconfig        |  2 +
> > >  configs/P1010RDB-PB_36BIT_NAND_defconfig      |  2 +
> > >  configs/P1010RDB-PB_36BIT_NOR_defconfig       |  2 +
> > >  configs/P1010RDB-PB_36BIT_SDCARD_defconfig    |  2 +
> > >  configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig  |  2 +
> > >  configs/P1010RDB-PB_NAND_defconfig            |  2 +
> > >  configs/P1010RDB-PB_NOR_defconfig             |  2 +
> > >  configs/P1010RDB-PB_SDCARD_defconfig          |  2 +
> > >  configs/P1010RDB-PB_SPIFLASH_defconfig        |  2 +
> > >  configs/P1020RDB-PC_36BIT_NAND_defconfig      |  3 +
> > >  configs/P1020RDB-PC_36BIT_SDCARD_defconfig    |  3 +
> > >  configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig  |  3 +
> > >  configs/P1020RDB-PC_36BIT_defconfig           |  3 +
> > >  configs/P1020RDB-PC_NAND_defconfig            |  3 +
> > >  configs/P1020RDB-PC_SDCARD_defconfig          |  3 +
> > >  configs/P1020RDB-PC_SPIFLASH_defconfig        |  3 +
> > >  configs/P1020RDB-PC_defconfig                 |  3 +
> > >  configs/P1020RDB-PD_NAND_defconfig            |  3 +
> > >  configs/P1020RDB-PD_SDCARD_defconfig          |  3 +
> > >  configs/P1020RDB-PD_SPIFLASH_defconfig        |  3 +
> > >  configs/P1020RDB-PD_defconfig                 |  3 +
> > >  configs/P2020RDB-PC_36BIT_NAND_defconfig      |  3 +
> > >  configs/P2020RDB-PC_36BIT_SDCARD_defconfig    |  3 +
> > >  configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig  |  3 +
> > >  configs/P2020RDB-PC_36BIT_defconfig           |  3 +
> > >  configs/P2020RDB-PC_NAND_defconfig            |  3 +
> > >  configs/P2020RDB-PC_SDCARD_defconfig          |  3 +
> > >  configs/P2020RDB-PC_SPIFLASH_defconfig        |  3 +
> > >  configs/P2020RDB-PC_defconfig                 |  3 +
> > >  doc/device-tree-bindings/net/fsl-tsec-phy.txt |  2 +-
> > >  drivers/net/fsl_mdio.c                        | 28 +++++++--
> > >  drivers/net/tsec.c                            | 62
> ++++++++-----------
> > >  include/configs/p1_p2_rdb_pc.h                |  2 +
> > >  include/fsl_mdio.h                            |  4 ++
> > >  include/tsec.h                                |  4 ++
> > >  68 files changed, 698 insertions(+), 63 deletions(-)  create mode
> > > 100644 arch/powerpc/dts/p1020rdb-pc.dtsi  create mode 100644
> > > arch/powerpc/dts/p2020rdb-pc.dtsi  create mode 100644
> > > arch/powerpc/dts/pq3-etsec1-0.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec1-1.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec1-2.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec1-3.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-0.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-1.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-2.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-grp2-0.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-grp2-1.dtsi
> > >  create mode 100644 arch/powerpc/dts/pq3-etsec2-grp2-2.dtsi
> > >
> > > --
> > > 2.25.1
> > >
> >
> > The point with the Acked-by/Reviewed-by/Tested-by tags is that you
> > copy them to your next patch submissions, such that the maintainers
> > see which patches have had eyes on them already, so that they don't
> > need to look through them again.
> >
> > Thanks,
> > -Vladimir
> 
> I'm sorry, please ignore this. I thought none of the patches have the
> Reviewed-by tag I added, but looks like those are in fact all the patches that I
> did review. Time to review the rest!

That's all right, and thanks again!

Regards,
Zhiqiang

> 
> Thanks,
> -Vladimir


More information about the U-Boot mailing list