[PATCH v2] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Thu Jul 30 13:48:40 CEST 2020


> Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") &
> commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"),
> CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default).
> It makes no sense to still carry code that is guarded with
> "#ifndef CONFIG_NR_DRAM_BANKS" (and similar). This patch removes
> all these unreferenced code paths.
> 
> Also complete remove bi_memstart & bi_memsize from the board-info
> struct. As now bi_dram[] is always enabled and should be used instead.
> This removes the redundant varriables.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Ramon Fried <ramon.fried at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Michal Simek <michal.simek at xilinx.com>
> ---
> v2:
> - Change all references to bi_memstart & bi_memsize to bi_dram[0].start/
>   size and remove it from the bd_info struct completely, as suggested by
>   Daniel
> 
>  api/api_platform-mips.c               |  4 ++--
>  api/api_platform-powerpc.c            |  2 +-
>  arch/arc/lib/cpu.c                    |  4 ++--
>  arch/mips/lib/boot.c                  |  2 +-
>  arch/mips/lib/bootm.c                 |  2 +-
>  arch/powerpc/cpu/mpc83xx/fdt.c        |  2 +-
>  arch/powerpc/cpu/mpc83xx/traps.c      |  2 +-
>  arch/powerpc/cpu/mpc85xx/fdt.c        |  4 ++--
>  arch/powerpc/cpu/mpc85xx/traps.c      |  2 +-
>  arch/powerpc/cpu/mpc86xx/fdt.c        |  2 +-
>  arch/powerpc/cpu/mpc86xx/traps.c      |  2 +-
>  arch/powerpc/cpu/mpc8xx/fdt.c         |  2 +-
>  arch/powerpc/lib/bootm.c              |  4 ++--
>  arch/x86/cpu/broadwell/cpu_from_spl.c |  2 --
>  arch/xtensa/lib/bootm.c               |  4 ++--
>  board/Arcturus/ucp1020/spl.c          |  4 ++--
>  board/cadence/xtfpga/xtfpga.c         |  4 ++--
>  board/freescale/p1010rdb/spl.c        |  4 ++--
>  board/freescale/p1_p2_rdb_pc/spl.c    |  4 ++--
>  board/freescale/t102xrdb/spl.c        |  4 ++--
>  board/freescale/t104xrdb/spl.c        |  4 ++--
>  board/freescale/t208xqds/spl.c        |  4 ++--
>  board/freescale/t208xrdb/spl.c        |  4 ++--
>  board/freescale/t4rdb/spl.c           |  4 ++--
>  board/xilinx/zynqmp/zynqmp.c          |  2 --
>  cmd/bdinfo.c                          |  6 ++----
>  cmd/bedbug.c                          |  2 +-
>  common/board_f.c                      | 10 +++-------
>  common/image.c                        | 12 ------------
>  common/init/handoff.c                 |  4 ----
>  drivers/pci/pci-uclass.c              | 17 +----------------
>  drivers/video/cfb_console.c           |  8 +-------
>  include/asm-generic/u-boot.h          |  4 ----
>  include/handoff.h                     |  2 --
>  lib/fdtdec.c                          |  5 -----
>  lib/lmb.c                             |  7 -------
>  36 files changed, 45 insertions(+), 110 deletions(-)
> 

nice cleanup, thanks.

Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>

-- 
- Daniel



More information about the U-Boot mailing list