[PATCH v1 3/3] pico-imx6ul: convert ethernet function to DM_ETH

wig wig.cheng at technexion.com
Fri Jul 31 08:12:20 CEST 2020


On 7/30/20 9:16 AM, Fabio Estevam wrote:
> On Tue, Jul 28, 2020 at 11:36 PM <wig.cheng at technexion.com> wrote:
>> From: Wig Cheng <wig.cheng at technexion.com>
>>
>> - Remove pinmux definition from pico-imx6ul.c
>> - Enable NET_RANDOM_ETHADDR for temporary solution, because micrel_ksz8xxx
>> driver does not support DM_ETH yet, so cannot read MAC address directly.
>>
>> Before enable DM_ETH:
>>    Net:   FEC [PRIME]
>>
>> After enable DM_ETH:
>>    Net:
>>    Warning: using random MAC address - ca:3f:43:8f:67:d4
>>    eth1: ethernet at 20b4000
>>
>> Here is the test commands:
>>    => dhcp
>>    BOOTP broadcast 1
>>    DHCP client bound to address 10.88.88.94 (139 ms)
>>    *** ERROR: `serverip' not set
>>    Cannot autoload with TFTPGET
>>    => ping 8.8.8.8
>>    Using ethernet at 20b4000 device
>>    host 8.8.8.8 is alive
>>
>> Signed-off-by: Wig Cheng <wig.cheng at technexion.com>
>> ---
>>   board/technexion/pico-imx6ul/pico-imx6ul.c | 53 ----------------------
>>   configs/pico-imx6ul_defconfig              |  2 +
>>   2 files changed, 2 insertions(+), 53 deletions(-)
>>
>> diff --git a/board/technexion/pico-imx6ul/pico-imx6ul.c b/board/technexion/pico-imx6ul/pico-imx6ul.c
>> index 5d6be26faa..126823fce0 100644
>> --- a/board/technexion/pico-imx6ul/pico-imx6ul.c
>> +++ b/board/technexion/pico-imx6ul/pico-imx6ul.c
>> @@ -18,7 +18,6 @@
>>   #include <asm/io.h>
>>   #include <common.h>
>>   #include <miiphy.h>
> This one could be also removed.

No, board_phy_config function need initial some registers for phy 
ethernet, and miiphy.h is required for initial function.

It will cause dhcp failed if I force to remove miiphy.h with initial 
function.

Because it's a series of three patches, although this patch has no any 
changed, but I still move to V2, thanks.



More information about the U-Boot mailing list