[PATCH v2 00/10] new rtc methods, rtc command, and tests

Rasmus Villemoes rasmus.villemoes at prevas.dk
Tue Jun 2 20:40:20 CEST 2020


On 20/05/2020 00.01, Rasmus Villemoes wrote:
> I need access to registers other than just the timekeeping ones of the
> pcf2127, so I wanted to implement ->read8 and ->write8. But for
> testing these it appeared there was no convenient way to invoke those
> from the shell, so I also ended up adding such a command.
> 
> Also, it seemed more natural to provide array variants that can read
> or write several registers at once, so rtc_ops is expanded a bit.
> 
> Changes in v2:
> 
> - Use simply "read" and "write" instead of "read8_array",
>   "write8_array", both for functions and methods, as suggested by
>   Simon.

Urgh. The name rtc_read() is already used for a local helper by a number
of rtc drivers (also rtc_write, for somewhat fewer drivers). So I can
still call the methods ->read and ->write, but the functions will need
another name. Probably dm_rtc_read/dm_rtc_write, since this is only for
DM-enabled drivers anyway, and matches the existing dm_rtc_get/dm_rtc_set.

Rasmus


More information about the U-Boot mailing list