[PATCH v2 00/10] new rtc methods, rtc command, and tests

Rasmus Villemoes rasmus.villemoes at prevas.dk
Tue Jun 2 21:44:23 CEST 2020


On 02/06/2020 21.29, Simon Glass wrote:
> Hi Rasmus,
> 
> On Tue, 2 Jun 2020 at 12:40, Rasmus Villemoes
> <rasmus.villemoes at prevas.dk> wrote:
>>
>> Urgh. The name rtc_read() is already used for a local helper by a number
>> of rtc drivers (also rtc_write, for somewhat fewer drivers). So I can
>> still call the methods ->read and ->write, but the functions will need
>> another name. Probably dm_rtc_read/dm_rtc_write, since this is only for
>> DM-enabled drivers anyway, and matches the existing dm_rtc_get/dm_rtc_set.
> 
> The conflict is OK, since at some point those drivers will be updated
> to DM or removed. I'd rather avoid the dm_ prefix if not necessary.

There are some DM-enabled drivers that still use those names as local
helpers, e.g. rx8025.c and pt7c4338.c.

Rasmus


More information about the U-Boot mailing list