[PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs

[Tom Rini]

On Wed, Jun 03, 2020 at 12:18:18AM +0000, Alex Nemirovsky wrote:
> Hi Tom,
> 
> > On Jun 2, 2020, at 6:02 AM, Tom Rini <trini at konsulko.com> wrote:
> > 
> > On Mon, Jun 01, 2020 at 07:44:25PM -0700, Alex Nemirovsky wrote:
> > 
> >> From: Aaron Tseng <aaron.tseng at cortina-access.com>
> >> 
> >> Add Cortina Access Ethernet device driver for CAxxxx SoCs.
> >> This driver supports both legacy and DM_ETH network models.
> >> 
> >> Signed-off-by: Aaron Tseng <aaron.tseng at cortina-access.com>
> >> Signed-off-by: Alex Nemirovsky <alex.nemirovsky at cortina-access.com>
> >> 
> >> CC: Joe Hershberger <joe.hershberger at ni.com>
> >> CC: Abbie Chang <abbie.chang at Cortina-Access.com>
> >> CC: Tom Rini <trini at konsulko.com>
> > [snip]
> >> +#define HEADER_A_SIZE	8
> >> +#define CORTINA_NI_DBG 1
> >> +/*define CORTINA_NI_DBG if individual rx,tx,init needs to be called */
> > 
> > We have pr_debug, etc, please use those and not a custom debug defiine.
> > 
> >> +#ifdef CONFIG_DM_ETH
> >> +#if CORTINA_NI_DBG
> >> +static struct udevice	*dbg_dev;
> >> +#endif
> >> +static struct udevice   *curr_dev;
> >> +#else
> > 
> > The deadline for drivers to convert to DM for ethernet is v2020.07.
> > Please rework to not introduce any legacy mode support.  Thanks!
> 
> For clarity, we are providing BOTH DM and Legacy mode support in our driver.
> Is the request to REMOVE Legacy mode support, even though DM support is already provided to meet the 2020.07 requirement?

Yes, remove the legacy code as there's no non-legacy users in upstream
to support.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200602/980f6649/attachment.sig>