[PATCH v2 1/8] arm64: dts: rk3399-puma: fix gpio levels for gmac reset pin

Kever Yang kever.yang at rock-chips.com
Fri Jun 5 04:22:14 CEST 2020


On 2020/6/4 下午6:09, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
>
> The gmac reset has opposite values for the gpio declaration
> and the separate reset-active, bring this in line to make
> u-boot also find the ethernet-phy.
>
> This mimics the upstream Linux commit found on
> https://lore.kernel.org/r/20200603132836.362519-1-heiko@sntech.de
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3399-puma.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
> index 07694b196f..531520e771 100644
> --- a/arch/arm/dts/rk3399-puma.dtsi
> +++ b/arch/arm/dts/rk3399-puma.dtsi
> @@ -157,7 +157,7 @@
>   	phy-mode = "rgmii";
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&rgmii_pins>;
> -	snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
> +	snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
>   	snps,reset-active-low;
>   	snps,reset-delays-us = <0 10000 50000>;
>   	tx_delay = <0x10>;




More information about the U-Boot mailing list