[PATCH] mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()

Tom Rini trini at konsulko.com
Fri Jun 5 14:30:16 CEST 2020


On Fri, Jun 05, 2020 at 10:16:53AM +0530, Lokesh Vutla wrote:
> 
> 
> On 05/06/20 1:33 am, Tom Rini wrote:
> > We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or
> > when we have to iodelay recalibration.  Add guards for these checks as
> > clang will otherwise warn.
> > 
> > Cc: Peng Fan <peng.fan at nxp.com>
> > Cc: Lokesh Vutla <lokeshvutla at ti.com>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> 
> Reviewed-by: Lokesh Vutla <lokeshvutla at ti.com>
> 
> > ---
> > Aside, Lokesh, can you please add drivers/mmc/omap_hsmmc.c to the
> > general TI entry MAINTAINERS entry?  Thanks!
> 
> We have a subsystem maintainer for MMC. IIUC, all the patches should go through
> subsystem if one is available, so I intentionally did not add omap_hsmmc under
> TI. Is my understanding wrong?

Yes.  While there is a subsystem maintainer, they aren't going to know
the IP-block quirks as well as the custodian for a given SoC, so
individual drivers should be listed under the SoC/arch entry as well.
get_maintainers.pl will list both when queried.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/32b5bb43/attachment.sig>


More information about the U-Boot mailing list