[PATCH] test: add dependency for UT_LOG

Heinrich Schuchardt xypron.glpk at gmx.de
Sun Jun 7 07:55:14 CEST 2020


Am June 7, 2020 3:52:37 AM UTC schrieb Kever Yang <kever.yang at rock-chips.com>:
>The callback of do_ut_log() is defined in test/log/test-main.c
>which is depend on CONFIG_LOG.

Where do you see such a dependency?

With which configuration did you have a build problem?

>
>Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>---
>
> test/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/test/Kconfig b/test/Kconfig
>index 9b2f84b551..8c32fa5cbd 100644
>--- a/test/Kconfig
>+++ b/test/Kconfig
>@@ -42,6 +42,7 @@ endif
> 
> config UT_LOG
> 	bool "Unit tests for logging functions"
>+	depends on LOG

This seems incorrect. We want to run the nolog test if CONFIG_LOG=n.

See https://github.com/trini/u-boot/blob/master/test/log/Makefile#L15

Best regards

Heinrich


> 	depends on UNIT_TEST
> 	default y
> 	help



More information about the U-Boot mailing list