[PATCH] buildman: Remove _of_#_ from results directory paths

Simon Glass sjg at chromium.org
Mon Jun 8 04:43:58 CEST 2020


Hi Ovidiu,

On Fri, 15 May 2020 at 00:32, Ovidiu Panait <ovidiu.panait at windriver.com> wrote:
>
> Currently, the following scenario will rebuild the first commit even
> though it is not really necessary - the commit sha or the position in the
> patchset did not change:
>
> $ git am <local-patch-0001>
> $ tools/buildman/buildman -P -E -W -b master mx6
> <do some more development work>
> $ git am <local-patch-0002>
> $ tools/buildman/buildman -P -E -W -b master mx6 <- will rebuild the first
>                                                     commit as well, even
>                                                     though nothing has
>                                                     changed about it.
>
> This is due to the fact that previous results directories get removed
> when the number of commits change. By removing the _of_#_ part of the
> directory path, the commits will be rebuilt only if the commit sha or the
> position in the patchset changes. Also, update the testcase to reflect this
> change.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait at windriver.com>
> ---
>
>  tools/buildman/builder.py | 10 +++++-----
>  tools/buildman/test.py    |  8 ++++----
>  2 files changed, 9 insertions(+), 9 deletions(-)

I've been thinking about changing this, so let's do it.

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list